chore: remove support for node <18 #349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
bjohansebas
commented
Aug 24, 2025
Comment on lines
+62
to
+69
| browsers: ["ChromeHeadless", "ChromeHeadlessCI"], | ||
|
|
||
| customLaunchers: { | ||
| ChromeHeadlessCI: { | ||
| base: "ChromeHeadless", | ||
| flags: ["--no-sandbox"] | ||
| } | ||
| }, |
There was a problem hiding this comment.
At some point when I did the rebase, I accidentally copied the original file from the next branch and didn’t fix it.
There was a problem hiding this comment.
Has this change something to do with dropping the support? Else please remove it.
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Phillip9587
reviewed
Oct 3, 2025
| "puppeteer": "^4.0.0", | ||
| "webpack": "^4.43.0" | ||
| "webpack": "^4.43.0", | ||
| "unorm": "^1.6.0" |
There was a problem hiding this comment.
Has this change something to do with dropping the support for node <18?
Comment on lines
+62
to
+69
| browsers: ["ChromeHeadless", "ChromeHeadlessCI"], | ||
|
|
||
| customLaunchers: { | ||
| ChromeHeadlessCI: { | ||
| base: "ChromeHeadless", | ||
| flags: ["--no-sandbox"] | ||
| } | ||
| }, |
There was a problem hiding this comment.
Has this change something to do with dropping the support? Else please remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify our Node.js support, and since it also aligns with our LTS rules, plus as I plan to investigate web stream support for browsers, it will be quite good to remove this old Node.js support.